Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

We've been using Gitlab side by side with Github for the past few months. In general it's a very nice replacement, but one thing I've been fighting with lately is code review capabilities.

The problem I've been having is when I go to a commit, in Github I'll be able to see what's changed (the diffs), but in Gitlab I often get "diff too big and not shown for perf reasons" or suchlike. This inability to reliably view diffs makes me wonder how we're going to do code review on projects hosted on Gitlab.

Does anyone else have experience with this, or any workarounds?



We too find the code review system in GitLab (and GitHub for that matter) to be lacking. We add the repository to Crucible and it automatically indexes the commits. We then do code reviews on GitLab branches there. Yes, Crucible is commercial but it's far above reviewboard, gerrit, etc.


The main workaround is to keep your commits small. If you run your own GitLab server your can also tune the constants that affect this behavior. If you have a good use-case feel free to send a merge request to increase them so they get better for everyone.


A use-case is "some people insist on making large commits". In a perfect world, maybe otherwise, but not this one.


Aha. I'll have a chat with the guy who administrates our install about tweaking the constants.

The example I had from this morning was quite a large diff (47 changed files). I'd rather have a large page load time and be able to see the diffs though.

Thanks for the suggestion. :)




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: